ci: run tests on pull requests from forks #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khawkins
reviewed
Jun 27, 2024
.github/workflows/test.yml
Outdated
|
|
||
| env: | ||
| UT_DISABLE_NODE_CURRENT: true | ||
| NODE_VERSION_OVERRIDE: [lts/-1, lts/*] |
There was a problem hiding this comment.
Do we need the NODE_VERSION_OVERRIDE? I thought this was already the criteria for the node version.
There was a problem hiding this comment.
I think this can be removed
There was a problem hiding this comment.
Yes it can be removed. I was just experimenting here. After adding UT_DISABLE_NODE_CURRENT: true for some reason PRs that are from forks are still failing due to wrong node version (see here) but PRs from branches on the main repo pass (see here)
This didn't make sense to me and I was just curious to see if by adding NODE_VERSION_OVERRIDE I can fix the issue.
nrkruk
approved these changes
Jun 27, 2024
maliroteh-sf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable running CI jobs on PRs from forks
What issues does this PR fix or reference?
@W-15906501@