Skip to content

Disable current node version #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Disable current node version #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26388bd
ci: disable current node version
maliroteh-sf Jun 27, 2024
664fd2d
ci: fix build break
maliroteh-sf Jun 27, 2024
95c2092
ci: comment out NUT placeholder tests
maliroteh-sf Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
branches-ignore: [main]
workflow_dispatch:

env:
UT_DISABLE_NODE_CURRENT: true

jobs:
yarn-lockfile-check:
uses: salesforcecli/github-workflows/.github/workflows/lockFileCheck.yml@main
Expand Down
30 changes: 15 additions & 15 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,33 +5,33 @@
"author": "Salesforce",
"bugs": "https://github.com/forcedotcom/cli/issues",
"dependencies": {
"@lwrjs/api": "0.13.0-alpha.19",
"@lwc/lwc-dev-server": "^7.1.3-6.6.7",
"@lwc/sfdc-lwc-compiler": "^7.1.3-6.6.7",
"@lwrjs/api": "0.13.0-alpha.22",
"@lwc/lwc-dev-server": "^8.1.1",
"@lwc/sfdc-lwc-compiler": "^8.1.1",
"@oclif/core": "^3.26.6",
"@salesforce/core": "^7.3.9",
"@salesforce/kit": "^3.1.2",
"@salesforce/kit": "^3.1.6",
"@salesforce/lwc-dev-mobile-core": "4.0.0-alpha.4",
"@salesforce/sf-plugins-core": "^9.1.1",
"@inquirer/select": "^2.3.5",
"@inquirer/select": "^2.3.7",
"chalk": "^5.3.0",
"lwc": "6.6.5",
"lwr": "0.13.0-alpha.19",
"lwc": "7.0.0",
"lwr": "0.13.0-alpha.22",
"node-fetch": "^3.3.2",
"tar": "^7.2.0"
"tar": "^7.4.0"
},
"devDependencies": {
"@oclif/plugin-command-snapshot": "^5.2.1",
"@salesforce/cli-plugins-testkit": "^5.3.9",
"@oclif/plugin-command-snapshot": "^5.2.3",
"@salesforce/cli-plugins-testkit": "^5.3.16",
"@salesforce/dev-scripts": "^9.1.2",
"@salesforce/plugin-command-reference": "^3.0.90",
"@salesforce/plugin-command-reference": "^3.1.6",
"@types/node-fetch": "^2.6.11",
"@types/tar": "^6.1.13",
"eslint-plugin-sf-plugin": "^1.18.5",
"esmock": "^2.6.5",
"oclif": "^4.12.3",
"eslint-plugin-sf-plugin": "^1.18.9",
"esmock": "^2.6.6",
"oclif": "^4.13.10",
"ts-node": "^10.9.2",
"typescript": "^5.4.5"
"typescript": "^5.5.2"
},
"engines": {
"node": ">=18.0.0 <22"
Expand Down
3 changes: 3 additions & 0 deletions test/commands/lightning/preview/app.nut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Licensed under the BSD 3-Clause license.
* For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
*/
// TODO - add proper NUT tests
/*
import { execCmd, TestSession } from '@salesforce/cli-plugins-testkit';
import { expect } from 'chai';

Expand All @@ -25,3 +27,4 @@ describe('lightning preview org NUTs', () => {
expect(output).to.contain(name);
});
});
*/
3 changes: 3 additions & 0 deletions test/commands/lightning/preview/component.nut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Licensed under the BSD 3-Clause license.
* For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
*/
// TODO - add proper NUT tests
/*
import { execCmd, TestSession } from '@salesforce/cli-plugins-testkit';
import { expect } from 'chai';

Expand All @@ -25,3 +27,4 @@ describe('lightning preview component NUTs', () => {
expect(output).to.contain(name);
});
});
*/
14 changes: 8 additions & 6 deletions test/commands/lightning/preview/site.nut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
* Licensed under the BSD 3-Clause license.
* For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
*/
// TODO - add proper NUT tests
/*
import { TestSession } from '@salesforce/cli-plugins-testkit';
// import { expect } from 'chai';
import { expect } from 'chai';

describe('lightning preview site NUTs', () => {
let session: TestSession;
Expand All @@ -18,11 +20,11 @@ describe('lightning preview site NUTs', () => {
await session?.clean();
});

// TODO
it('should display provided name', () => {
// const name = 'World';
// const command = `lightning preview site --name ${name}`;
// const output = execCmd(command, { ensureExitCode: 0 }).shellOutput.stdout;
// expect(output).to.contain(name);
const name = 'World';
const command = `lightning preview site --name ${name}`;
const output = execCmd(command, { ensureExitCode: 0 }).shellOutput.stdout;
expect(output).to.contain(name);
});
});
*/
Loading