Pass Identity token to LWC Dev Server #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliroteh-sf
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Looks like #67 went in before this one, so you have some conflicts to resolved but other than that LGTM
| @@ -72,6 +74,7 @@ async function createLWCServerConfig(rootDir: string, logger: Logger): Promise<S | |||
| paths: namespacePaths, | |||
| workspace: await LwcDevServerUtils.getLocalDevServerWorkspace(), | |||
| targets: ['LEX'], // should this be something else? | |||
| identityToken, | |||
There was a problem hiding this comment.
in order to be aligned with the way we pass the params, maybe we should update this to identityToken: identityToken instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To be merged after #52 is merged.
It passes the Identity token to the LWC Dev Server
What issues does this PR fix or reference?