feat(dev-server): integrate with preview app command #49
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -183,6 +183,4 @@ FLAG DESCRIPTIONS | |
| This person can be anyone in the world! | ||
| ``` | ||
|
|
||
| <!-- commandsstop --> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| /* | ||
| * Copyright (c) 2023, salesforce.com, inc. | ||
| * All rights reserved. | ||
| * Licensed under the BSD 3-Clause license. | ||
| * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause | ||
| */ | ||
|
|
||
| import { existsSync, lstatSync, readFileSync } from 'node:fs'; | ||
| import path from 'node:path'; | ||
| import process from 'node:process'; | ||
| import { LWCServer, LogLevel, ServerConfig, Workspace, startLwcDevServer } from '@lwc/lwc-dev-server'; | ||
| import { Logger } from '@salesforce/core'; | ||
|
|
||
| const DEV_SERVER_PORT = 8081; | ||
|
There was a problem hiding this comment. The port needs to be configurable. This a pretty popular port number and we should anticipate that it might not be available. Can we add a new flag to There was a problem hiding this comment. @ravijayaramappa we may need to run it by Marcelino to discuss this. For example:
Maybe we should utilize our slack channel to discuss further with him and the devs? There was a problem hiding this comment. I like that idea of just putting it in the |
||
|
|
||
| /** | ||
| * Map sf cli log level to lwc dev server log level | ||
| * https://github.com/salesforcecli/cli/wiki/Code-Your-Plugin#logging-levels | ||
| * | ||
| * @param cliLogLevel | ||
| * @returns number | ||
| */ | ||
| function mapLogLevel(cliLogLevel: number): number { | ||
| switch (cliLogLevel) { | ||
| case 10: | ||
| return LogLevel.verbose; | ||
| case 20: | ||
| return LogLevel.debug; | ||
| case 30: | ||
| return LogLevel.info; | ||
| case 40: | ||
| return LogLevel.warn; | ||
| case 50: | ||
| return LogLevel.error; | ||
| case 60: | ||
| return LogLevel.silent; | ||
| default: | ||
| return LogLevel.error; | ||
| } | ||
| } | ||
|
|
||
| function createLWCServerConfig(rootDir: string, logger: Logger): ServerConfig { | ||
| const sfdxConfig = path.resolve(rootDir, 'sfdx-project.json'); | ||
|
|
||
| if (!existsSync(sfdxConfig) || !lstatSync(sfdxConfig).isFile()) { | ||
| throw new Error(`sfdx-project.json not found in ${rootDir}`); | ||
| } | ||
|
|
||
| const sfdxConfigJson = readFileSync(sfdxConfig, 'utf-8'); | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment | ||
| const { packageDirectories } = JSON.parse(sfdxConfigJson); | ||
| const namespacePaths: string[] = []; | ||
|
|
||
| for (const dir of packageDirectories) { | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access | ||
| if (dir.path) { | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-argument | ||
| const resolvedDir = path.resolve(rootDir, dir.path, 'main', 'default'); | ||
| if (existsSync(resolvedDir) && lstatSync(resolvedDir).isDirectory()) { | ||
| logger.debug(`Adding ${resolvedDir} to namespace paths`); | ||
| namespacePaths.push(resolvedDir); | ||
| } else { | ||
| logger.warn(`Skipping ${resolvedDir} because it does not exist or is not a directory`); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return { | ||
| rootDir, | ||
| port: DEV_SERVER_PORT, | ||
| protocol: 'wss', | ||
| host: 'localhost', | ||
rax-it marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| paths: namespacePaths, | ||
| workspace: Workspace.SfCli, | ||
| targets: ['LEX'], // should this be something else? | ||
rax-it marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| logLevel: mapLogLevel(logger.getLevel()), | ||
| }; | ||
| } | ||
|
|
||
| export async function startLWCServer(rootDir: string, logger: Logger): Promise<LWCServer> { | ||
| const config = createLWCServerConfig(rootDir, logger); | ||
| logger.trace(`Starting LWC Dev Server with config: ${JSON.stringify(config)}`); | ||
| let lwcDevServer: LWCServer | null = await startLwcDevServer(config); | ||
|
|
||
| const cleanup = (): void => { | ||
| if (lwcDevServer) { | ||
| logger.trace('Stopping LWC Dev Server'); | ||
| lwcDevServer.stopServer(); | ||
| lwcDevServer = null; | ||
| } | ||
| }; | ||
|
|
||
| [ | ||
| 'exit', // normal exit flow | ||
| 'SIGINT', // when a user presses ctrl+c | ||
| 'SIGTERM', // when a user kills the process | ||
| ].forEach((signal) => process.on(signal, cleanup)); | ||
|
|
||
| return lwcDevServer; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| // Intentionally blank file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| // Intentionally blank file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "packageDirectories": [ | ||
| { | ||
| "path": "force-app" | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.