feat: scaffolding for single component preview command @W-17803218 #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrkruk
changed the title
lpomerleau
reviewed
Feb 12, 2025
Comment on lines
+9
to
+18
| # flags.name.summary | ||
|
|
||
| Description of a flag. | ||
|
|
||
| # flags.name.description | ||
|
|
||
| More information about a flag. Don't repeat the summary. | ||
|
|
||
| # examples | ||
|
|
There was a problem hiding this comment.
yeah, will be done by doc team
| @@ -0,0 +1,30 @@ | |||
| /* | |||
There was a problem hiding this comment.
are these test files necessary? they don't do anything
There was a problem hiding this comment.
Brian will add these tests. Just created the initial file structure
| char: 'n', | ||
| required: false, | ||
| }), | ||
| // TODO should this be required or optional? |
There was a problem hiding this comment.
Will let Brian decide based off what he has time to implement. If we don't make it required, will need to do some code scanning of the component u are attempting to preview, then error out if it needs data and you don't supply an authenticated org. Just added todo comment as a reminder
lpomerleau
approved these changes
Feb 12, 2025
nrkruk
added a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
sf lightning dev componentcommandWhat issues does this PR fix or reference?
@W-17803218@