Skip to content

feat: [sites] add get-latest cli parameter / update lwr -> v0.16.2 (includes latest local-dev fixes) #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

nrkruk
Copy link
Collaborator

@nrkruk nrkruk commented Jan 11, 2025

What does this PR do?

  • feat: add cli parameter to force refresh of locally cached site
  • fix: bug causing sites with basePaths to not render correctly
  • fix: auth related proxy issues for sites
  • fix: Site preview not working with unpublished sites. Default API generation to use publish site shape until fixed in future patch release.
  • chore: update LWR to v0.16.2
  • doc: update cli text indicating sites is still in Beta
  • doc: better error message handling

What issues does this PR fix or reference?

@W-17046400@ @W-17312145@ @W-17178650@

fixes: #199

@nrkruk nrkruk self-assigned this Jan 11, 2025
@nrkruk nrkruk marked this pull request as ready for review January 13, 2025 09:36
@nrkruk nrkruk requested review from a team as code owners January 13, 2025 09:36
@@ -21,7 +21,7 @@ const messages = Messages.loadMessages('@salesforce/plugin-lightning-dev', 'prom

export class PromptUtils {
public static async promptUserToSelectSite(sites: string[]): Promise<string> {
const choices = sites.map((site) => ({ value: site }));
const choices = sites.sort((a, b) => a.localeCompare(b)).map((site) => ({ value: site }));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order alphabetically


return experienceSites;
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused code

this.log(`[local-dev] initializing: ${siteName}`);
// If the site is not setup / is not based on the current release / or get-latest is requested ->
// generate and download a new site bundle from the org based on latest builder metadata
if (!selectedSite.isSiteSetup() || getLatest) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Published sites are no longer tracked in an orgs static resources, so we will always use our local cache of initialized sites unless the user specifically requests the latest version of a site from the org

@nrkruk nrkruk changed the title wip: update prerelease with latest fixes feat: [sites] add get-latest cli parameter / update deps to include latest LWR fixes Jan 13, 2025
@nrkruk nrkruk changed the title feat: [sites] add get-latest cli parameter / update deps to include latest LWR fixes feat: [sites] add get-latest cli parameter / update lwr -> v0.16.2 (includes latest local-dev fixes) Jan 13, 2025
@nrkruk nrkruk merged commit 03fd833 into 254-patch Jan 13, 2025
17 checks passed
@nrkruk nrkruk deleted the nkruk/updatePrerelease-0.16 branch January 13, 2025 10:23
nrkruk added a commit that referenced this pull request Feb 11, 2025
* feat: 254-patch prerelease @W-15440507@ (#300)

* chore(release): 2.8.0 [skip ci]

* feat: [sites] add `get-latest` cli parameter / update lwr -> v0.16.2 (includes latest local-dev fixes) (#311)

* chore(release): 2.9.0 [skip ci]

* feat: add api flags for testing (#319)

* chore(release): 2.10.0 [skip ci]

* chore: update lwc oss dependency to 8.10.3 to match spring25 @W-17663897 (#320)

* chore: update lwc oss dependency to 8.10.3 to match spring25

* fix: pin to same minor version as salesforce core's lwc dependencies

* fix: adopt lwr v0.16.3 (#325)

- address authentication cookie issues
- render commerce b2b store
- enable switching between auth / guest user mode

* chore(release): 2.10.1 [skip ci]

* fix: hot reload not working on windows (#330)

* chore(release): 2.10.2 [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant