fix: download site bundle correctly if site name has special chars #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrkruk
reviewed
Nov 21, 2024
src/shared/experience/expSite.ts
Outdated
| if (isInvalidSiteName) { | ||
| const updatedSiteName = replaceSpacesAndSpecialChars(this.siteName); | ||
| this.siteName = updatedSiteName; | ||
| } |
There was a problem hiding this comment.
@pulkit0555 Is there a reason why we can't do this in the constructor?
There was a problem hiding this comment.
@nrkruk I was also debating on the same idea in a different PR to add these changes in the constructor but I guess that was missed. Let me add those changes now.
nrkruk
approved these changes
Nov 22, 2024
nrkruk
added a commit
that referenced
this pull request
Dec 17, 2024
…l chars (#270) * fix: download site bundle correctly if site name has special chars (#262) * fix: updated special chars in site name * fix: minor fix * fix: refactored code * chore: change test naming --------- Co-authored-by: Nicolas Kruk <nicolaskruk@gmail.com> Co-authored-by: Nicolas Kruk <nkruk@salesforce.com> Co-authored-by: svc-cli-bot <Svc_cli_bot@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the bug when site name contains special chars and we need to download site bundle
What issues does this PR fix or reference?
@W-16552899@