fix: bump target API version to 63.0 to match main codeline #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulsattar
requested review from
maliroteh-sf
and removed request for
a team
maliroteh-sf
approved these changes
Nov 1, 2024
maliroteh-sf
reviewed
Nov 4, 2024
| @@ -34,7 +34,7 @@ | |||
| "typescript": "^5.5.4" | |||
| }, | |||
| "engines": { | |||
| "node": ">=18.0.0 <22" | |||
| "node": ">=18.0.0 <23" | |||
There was a problem hiding this comment.
Should this now be >=20 <23 since 18 is no longer supported?
There was a problem hiding this comment.
I based this on the fact that the cli still supports 18: https://github.com/salesforcecli/cli/blob/8ead09d20a321cd847753e1f27a2ef075c9a5ce9/package.json#L13 and that Node@18 is in maintenance
maliroteh-sf
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps target API version to 63.0 to track main
What issues does this PR fix or reference?
@W-17117927@