Skip to content

fix: re-authorization is needed even if the offline app is already authorized #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

haifeng-li-at-salesforce
Copy link
Contributor

The Salesforce logger looks for transformStream by using the relative path ../../lib/loggger/transformStream. This function belongs to @Salesforce-core. The fix is to modify bundle:extentions and make the salesforce-core external to the generated extension.js

@haifeng-li-at-salesforce haifeng-li-at-salesforce requested a review from a team as a code owner July 16, 2024 17:16
@sfdctaka
Copy link
Contributor

Why is there so much shift in lines in the file diff do you know?

@khawkins
Copy link
Collaborator

Why is there so much shift in lines in the file diff do you know?

I think the file was reformatted, where I don't think it had gone through formatting before. I think the only non-formatting change is line 92.

@haifeng-li-at-salesforce
Copy link
Contributor Author

Why is there so much shift in lines in the file diff do you know?

Yes, it is due to the formatting. The only change is line 92

Copy link
Contributor

@sfdctaka sfdctaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haifeng-li-at-salesforce haifeng-li-at-salesforce merged commit 7bc3316 into salesforce:main Jul 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants