Skip to content

LanguageClient ID. And, use node script to copy yaml file. #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

sfdctaka
Copy link
Contributor

What does this PR do?

Implemented feedback from last PR.

  • Updated LanguageClient's ID.
  • Use node script to determine the platform(Windows vs Unix) where it is running and run appropriate copy command.

@sfdctaka sfdctaka requested a review from khawkins November 19, 2024 19:34
@khawkins
Copy link
Collaborator

One more change to be made: line 103 of package.json needs to be updated from:

        "bundle:extension": "esbuild ./src/extension.ts --bundle --outdir=out --format=cjs --target=es2020 --platform=node --external:vscode --external:@salesforce/core --external:@oclif/core --external:@salesforce/lwc-dev-mobile-core --minify --sourcemap",

to:

        "bundle:extension": "esbuild ./src/extension.ts --bundle --outdir=out/src --format=cjs --target=es2020 --platform=node --external:vscode --external:@salesforce/core --external:@oclif/core --external:@salesforce/lwc-dev-mobile-core --minify --sourcemap",

--outdir needs to be updated to the new output location.

@sfdctaka
Copy link
Contributor Author

Added package-lock.json which was supposed to be in the last PR.

@sfdctaka sfdctaka merged commit 96d71a4 into salesforce:main Nov 19, 2024
7 checks passed
@sfdctaka sfdctaka deleted the feedbackFromLastPR branch November 19, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants