Bug fixes #60
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,8 +8,13 @@ | |
| 'use strict'; | ||
|
|
||
| const { extname } = require('path'); | ||
| const { | ||
| setLwcBundleCacheEntry, | ||
| removeLwcBundleCacheEntry, | ||
| extractBundleKey | ||
| } = require('./util/helper'); | ||
| const LwcBundle = require('./lwc-bundle'); | ||
| const bundleStateManager = require('./util/bundle-state-manager'); | ||
|
|
||
| const SUPPORTS_AUTOFIX = true; | ||
|
|
||
|
|
@@ -83,6 +88,13 @@ class BundleAnalyzer { | |
| * @returns {{ text: string, filename: string }[]} An array of files and their content, to be processed. | ||
| */ | ||
| preprocess = (text, filename) => { | ||
| // Check if this is a file we generated ourselves with `preprocess()` return values. | ||
| const bundleKey = extractBundleKey(filename); | ||
| if (bundleStateManager.hasBundleWithKey(bundleKey)) { | ||
| // Skip processing for files we generated | ||
| return [{ text, filename }]; | ||
|
There was a problem hiding this comment. Does this fix recursive processing? There was a problem hiding this comment. Yes. The renaming we do at the bottom of the method causes ESLint to (re-)process this "new" file that we created. Conversely, when you return what you got in the processor, ESLint continues on with the rest of the process (i.e. considers that file pre-processed). |
||
| } | ||
|
|
||
| const fileExtension = extname(filename); | ||
|
|
||
| // If this.#lwcBundle has already been set, use that data. Otherwise, create | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Copyright (c) 2025, salesforce.com, inc. | ||
| * All rights reserved. | ||
| * SPDX-License-Identifier: MIT | ||
| * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| /** | ||
| * Interface for static analysis functionality | ||
| */ | ||
| class StaticAnalyzerInterface { | ||
|
There was a problem hiding this comment. Is this a mirror from Komaci library? There was a problem hiding this comment. Not per se. It was just a way to abstract the Komaci analysis functions we use, so that I could create a mock provider in test, to test how the analysis output impacted different parts of the reporting. You can see some of the mocked analysis tests below. |
||
| constructor() { | ||
| if (this.constructor === StaticAnalyzerInterface) { | ||
| throw new TypeError( | ||
| 'StaticAnalyzerInterface is an abstract class and cannot be instantiated directly' | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Generates priming diagnostics for a module | ||
| * @param {Object} options - The options for generating diagnostics | ||
| * @param {string} options.type - The type of module | ||
| * @param {string} options.namespace - The namespace of the module | ||
| * @param {string} options.name - The name of the module | ||
| * @param {Object<string, string>} options.files - The files to analyze | ||
| * @returns {Array<Object>} The generated diagnostics | ||
| */ | ||
| // eslint-disable-next-line no-unused-vars | ||
| generatePrimingDiagnosticsModule(options) { | ||
| throw new Error('Method not implemented'); | ||
| } | ||
|
|
||
| /** | ||
| * Gets the diagnostic messages catalog | ||
| * @returns {Object} The diagnostic messages catalog | ||
| */ | ||
| get diagnosticMessages() { | ||
| throw new Error('Method not implemented'); | ||
| } | ||
| } | ||
|
|
||
| module.exports = StaticAnalyzerInterface; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /* | ||
| * Copyright (c) 2025, salesforce.com, inc. | ||
| * All rights reserved. | ||
| * SPDX-License-Identifier: MIT | ||
| * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| const StaticAnalyzerInterface = require('./static-analyzer-interface'); | ||
| const staticAnalyzer = require('@komaci/static-analyzer'); | ||
|
|
||
| /** | ||
| * Concrete implementation of StaticAnalyzerInterface that uses the actual static analyzer | ||
| */ | ||
| class StaticAnalyzerProvider extends StaticAnalyzerInterface { | ||
|
There was a problem hiding this comment. I pulled this out into its own interface implementation so we could test the outputs coming from the static analysis. |
||
| generatePrimingDiagnosticsModule(options) { | ||
| return staticAnalyzer.generatePrimingDiagnosticsModule(options); | ||
| } | ||
|
|
||
| get diagnosticMessages() { | ||
| return staticAnalyzer.diagnosticMessages; | ||
| } | ||
| } | ||
|
|
||
| module.exports = StaticAnalyzerProvider; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
htmloverrides is removed, will any rule be applied to html files?