Upgrade static analyzer and other miscellaneous dependency #56
Conversation
ben-zhang-at-salesforce
requested review from
khawkins,
dbreese,
sfdctaka,
maliroteh-sf and
a team
as code owners
| @@ -54,7 +54,7 @@ | |||
| "chai": "^4.5.0" | |||
| }, | |||
| "dependencies": { | |||
| "@komaci/static-analyzer": "^250.0.2", | |||
| "@komaci/static-analyzer": "^252.1.0", | |||
There was a problem hiding this comment.
this is the latest published static analyzer: 252.1.0. will do an update when 254 is published.
There was a problem hiding this comment.
version 254 of static-analyzer hasn't been deployed to npmjs.com yet. so we still can't refer it as dependency yet.
There was a problem hiding this comment.
And we won't want to until we pull the trigger on 254 support—soon after the final deployment, is when we'll likely take that on. 👍
| @@ -26,4 +26,4 @@ updates: | |||
| - dependency-name: '@salesforce/dev-scripts' | |||
| # Don't upgrade Komaci until we meet its respective release boundary. | |||
| - dependency-name: '@komaci/static-analyzer' | |||
| versions: ['>= 252.0.0'] | |||
| versions: ['>= 254.0.0'] | |||
There was a problem hiding this comment.
Should this be 252 or 254 as you have it?
There was a problem hiding this comment.
I think it should 254. My understanding is this versions is for dependabot to ignore if dependabot detects there's >= 254 version. it will create pr if less than 254. so manual pr for cross version, auto pr if still in 252.
Update komaci/static-analyzer and other miscellaneous dependencies. Originally expected possible big change turned to be just a version number change.