Massive updat to IJ Aspects #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transitives cause issues in self-hosted Eclipse with duplicate bundles. We should be a good citizen and not contribute duplicate bundles to the target platform.
The lifetime of the cache is tightly coupled to the model manager. Thus, it makes sense to move this into the model manager class, which forces better design.
The IJ Aspects progressed quite a bit. A new templating system was introduced to create aspects with different behavior depending on the Bazel version. Additional the design was modified so that aspects are no longer added as a repository but become part of the workspace, i.e. they are copied into the workspace during sync. This seems to work better with Bazel caching (according to the IJ Aspects commit history). When importing aspects we no longer consume them as a repository. Instead we build them directly in the IJ repository and then copy & extract into our zip archive. The zip archive is later extracted into a temp location for better working with multiple Bazel workspaces.
This was referenced Apr 10, 2025
|
Thanks for the upgrade!!! Got into this error while Added these 2 lines solved it. |
|
@AnqiHuangQiQi These seem to be specific problems with the JDK you are using. Please make sure you are using Eclipse Temurin JDK 21. |
rsalvador
approved these changes
Apr 11, 2025
lonhutt
approved these changes
Apr 21, 2025
|
Hi. Qq when will this PR get checked-in? |
|
Thank you! I'm actually curious when will this change be ready on Bazel-vscode-java extension pre-release version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IJ Aspects progressed quite a bit. A new templating system was
introduced to create aspects with different behavior depending on the
Bazel version.
Additional the design was modified so that aspects are no longer added
as a repository but become part of the workspace, i.e. they are copied
into the workspace during sync. This seems to work better with Bazel
caching (according to the IJ Aspects commit history).
When importing aspects we no longer consume them as a repository.
Instead we build them directly in the IJ repository and then copy &
extract into our zip archive. The zip archive is later extracted into a
temp location for better working with multiple Bazel workspaces.