Skip to content

Introduce a JDTLS product #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Introduce a JDTLS product #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb74888
Add a JDTLS product for easier consumption
guw Mar 6, 2025
e84791f
Remove obsolete file
guw Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ jobs:
path: |
releng/products/scip-bazel-ls/target/products/*.tar.gz
releng/products/scip-bazel-ls/target/products/*.zip
releng/products/jdt-bazel-ls/target/products/*.tar.gz
releng/products/jdt-bazel-ls/target/products/*.zip
if-no-files-found: error

event_file:
Expand Down
11 changes: 0 additions & 11 deletions eclipse_sdk.sh
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions releng/mavenparent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,10 +341,10 @@
<configuration>
<products>
<product>
<!-- adjust configuration of the language server product (https://github.com/eclipse-tycho/tycho/issues/913#issuecomment-1122529505) -->
<id>scip-bazel-language-server.product</id>
<archiveFileName>scip-bazel-ls</archiveFileName>
<rootFolder>scip-bazel-ls</rootFolder>
<!-- adjust configuration of the language server product (https://github.com/eclipse-tycho/tycho/issues/913#issuecomment-1126680550) -->
<id>${tycho.product.uid}</id>
<archiveFileName>${tycho.product.launcher.name}</archiveFileName>
<rootFolder>${tycho.product.launcher.name}</rootFolder>
</product>
</products>
</configuration>
Expand Down
103 changes: 103 additions & 0 deletions releng/products/jdt-bazel-ls/jdt-bazel-language-server.product
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
<?xml version="1.0" encoding="UTF-8"?>
<?pde version="3.5"?>

<product name="JDT Language Server with Bazel Extension" uid="jdt-bazel-ls" id="org.eclipse.jdt.ls.core.product" application="org.eclipse.jdt.ls.core.id1" version="1.0.0" type="bundles" includeLaunchers="true" autoIncludeRequirements="true">

<configIni use="default">
</configIni>

<launcherArgs>
<programArgs>-nosplash
</programArgs>
<vmArgs>--add-modules=ALL-SYSTEM
--add-opens
java.base/java.util=ALL-UNNAMED
--add-opens
java.base/java.lang=ALL-UNNAMED
</vmArgs>
<vmArgsMac>-XstartOnFirstThread -Dorg.eclipse.swt.internal.carbon.smallFonts
</vmArgsMac>
</launcherArgs>

<windowImages/>

<launcher name="jdt-bazel-ls">
<win useIco="false">
<bmp/>
</win>
</launcher>

<vm>
</vm>

<plugins>
<plugin id="ch.qos.logback.classic"/>
<plugin id="ch.qos.logback.core"/>
<plugin id="com.salesforce.bazel.eclipse.core"/>
<plugin id="com.salesforce.bazel.eclipse.jdtls"/>
<plugin id="com.salesforce.bazel.importedsource"/>
<plugin id="com.salesforce.bazel.logback"/>
<plugin id="com.salesforce.bazel.sdk"/>
<plugin id="jakarta.servlet-api" version="5.0.0"/>
<plugin id="org.apache.commons.commons-codec"/>
<plugin id="org.apache.felix.scr"/>
<plugin id="org.eclipse.ant.core"/>
<plugin id="org.eclipse.buildship.core"/>
<plugin id="org.eclipse.compare.core"/>
<plugin id="org.eclipse.core.commands"/>
<plugin id="org.eclipse.core.contenttype"/>
<plugin id="org.eclipse.core.expressions"/>
<plugin id="org.eclipse.core.filesystem"/>
<plugin id="org.eclipse.core.jobs"/>
<plugin id="org.eclipse.core.net"/>
<plugin id="org.eclipse.core.resources"/>
<plugin id="org.eclipse.core.runtime"/>
<plugin id="org.eclipse.core.variables"/>
<plugin id="org.eclipse.debug.core"/>
<plugin id="org.eclipse.equinox.app"/>
<plugin id="org.eclipse.equinox.common"/>
<plugin id="org.eclipse.equinox.preferences"/>
<plugin id="org.eclipse.equinox.registry"/>
<plugin id="org.eclipse.equinox.security"/>
<plugin id="org.eclipse.equinox.security.linux"/>
<plugin id="org.eclipse.equinox.security.macosx"/>
<plugin id="org.eclipse.equinox.security.win32"/>
<plugin id="org.eclipse.jdt.apt.pluggable.core"/>
<plugin id="org.eclipse.jdt.core"/>
<plugin id="org.eclipse.jdt.launching"/>
<plugin id="org.eclipse.jdt.launching.macosx"/>
<plugin id="org.eclipse.jdt.ls.core"/>
<plugin id="org.eclipse.jdt.ls.filesystem"/>
<plugin id="org.eclipse.jdt.ls.logback.appender"/>
<plugin id="org.eclipse.justj.openjdk.hotspot.jre.minimal.stripped"/>
<plugin id="org.eclipse.m2e.apt.core"/>
<plugin id="org.eclipse.m2e.core"/>
<plugin id="org.eclipse.m2e.jdt"/>
<plugin id="org.eclipse.m2e.maven.runtime"/>
<plugin id="org.eclipse.m2e.workspace.cli"/>
<plugin id="org.eclipse.osgi"/>
<plugin id="org.eclipse.osgi.compatibility.state"/>
<plugin id="org.eclipse.osgi.services"/>
<plugin id="org.eclipse.text"/>
<plugin id="org.eclipse.xtext.xbase.lib"/>
</plugins>

<configurations>
<plugin id="ch.qos.logback.classic" autoStart="true" startLevel="2" />
<plugin id="org.apache.aries.spifly.dynamic.bundle" autoStart="true" startLevel="2" />
<plugin id="org.apache.felix.scr" autoStart="true" startLevel="2" />
<plugin id="org.eclipse.core.runtime" autoStart="true" startLevel="0" />
<plugin id="org.eclipse.equinox.common" autoStart="true" startLevel="2" />
<plugin id="org.eclipse.jdt.core" autoStart="false" startLevel="0" />
<plugin id="org.eclipse.jdt.launching" autoStart="false" startLevel="0" />
<plugin id="org.eclipse.jdt.ls.core" autoStart="true" startLevel="0" />
</configurations>

<preferencesInfo>
<targetfile overwrite="false"/>
</preferencesInfo>

<cssInfo>
</cssInfo>

</product>
2 changes: 1 addition & 1 deletion releng/products/scip-bazel-ls/scip-bazel-language-server.product
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<?pde version="3.5"?>

<product name="Scip Bazel Language Server" uid="scip-bazel-language-server.product" id="com.salesforce.bazel.scipls.product.server" application="com.salesforce.bazel.scipls.app.server" version="1.0.0" type="bundles" includeLaunchers="true" autoIncludeRequirements="true">
<product name="Scip Bazel Language Server" uid="scip-bazel-ls" id="com.salesforce.bazel.scipls.product.server" application="com.salesforce.bazel.scipls.app.server" version="1.0.0" type="bundles" includeLaunchers="true" autoIncludeRequirements="true">

<configIni use="default">
</configIni>
Expand Down
4 changes: 3 additions & 1 deletion releng/target-platform/target-platform.target
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde?>
<!-- generated with https://github.com/eclipse-cbi/targetplatform-dsl -->
<target name="bazel-eclipse-feature-target-platform" sequenceNumber="1741250669">
<target name="bazel-eclipse-feature-target-platform" sequenceNumber="1741253888">
<locations>
<location includeMode="planner" includeAllPlatforms="false" includeSource="true" includeConfigurePhase="true" type="InstallableUnit">
<unit id="org.eclipse.e4.rcp.feature.group" version="4.34.0.v20241113-2009"/>
Expand Down Expand Up @@ -58,6 +58,8 @@
</location>
<location includeMode="planner" includeAllPlatforms="false" includeSource="true" includeConfigurePhase="true" type="InstallableUnit">
<unit id="org.eclipse.jdt.ls.core" version="1.45.0.202502271238"/>
<unit id="org.eclipse.jdt.ls.filesystem" version="1.45.0.202502271238"/>
<unit id="org.eclipse.jdt.ls.logback.appender" version="1.45.0.202502271238"/>
<repository location="https://download.eclipse.org/jdtls/milestones/1.45.0/repository/"/>
</location>
<location includeMode="planner" includeAllPlatforms="false" includeSource="true" includeConfigurePhase="true" type="InstallableUnit">
Expand Down
2 changes: 2 additions & 0 deletions releng/target-platform/target-platform.tpd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ location "https://download.eclipse.org/releases/2024-12/" {

location "https://download.eclipse.org/jdtls/milestones/1.45.0/repository/" {
org.eclipse.jdt.ls.core
org.eclipse.jdt.ls.filesystem
org.eclipse.jdt.ls.logback.appender
}

// locations below taken from eclipse.jdt.ls project (to allow building the JDT LS in same workspace)
Expand Down
Loading