-
Notifications
You must be signed in to change notification settings - Fork 18
Add classpath_depth to allow controlling transitive dependency depth #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool feature. Doesn't Eclipse complain though if it can't find necessary classes when it launches tests?
Yes, good call out. I need to think though this one, I know IJ invokes bazel to remove the classpath in the IDE from causing issues, may have to do something similar, or figure out a way to store the actual runtime classpath outside Eclipse's project model. |
...rce/bazel/eclipse/core/model/discovery/BuildFileAndVisibilityDrivenProvisioningStrategy.java
Show resolved
Hide resolved
...rce/bazel/eclipse/core/model/discovery/BuildFileAndVisibilityDrivenProvisioningStrategy.java
Show resolved
Hide resolved
...e.bazel.eclipse.core/src/com/salesforce/bazel/eclipse/core/projectview/BazelProjectView.java
Outdated
Show resolved
Hide resolved
...l.eclipse.core/src/com/salesforce/bazel/eclipse/core/projectview/BazelProjectFileReader.java
Outdated
Show resolved
Hide resolved
.../com/salesforce/bazel/eclipse/core/model/discovery/ProjectPerTargetProvisioningStrategy.java
Outdated
Show resolved
Hide resolved
...pse.core/src/com/salesforce/bazel/eclipse/core/model/discovery/JavaAspectsClasspathInfo.java
Outdated
Show resolved
Hide resolved
@brian-mcnamara I think it would be good to capture the motivation for this change. Perhaps we should open an issue and add a few screenshots or some date showing before and/or after timings/memory consumption? |
...pse.core/src/com/salesforce/bazel/eclipse/core/model/discovery/BaseProvisioningStrategy.java
Show resolved
Hide resolved
...pse.core/src/com/salesforce/bazel/eclipse/core/model/discovery/JavaAspectsClasspathInfo.java
Outdated
Show resolved
Hide resolved
I renamed |
hmm ... should we use |
Not opposed to that, the only thing that may be confusing is setting the value to 0, which in the current implementation means exclude all runtime dependencies, but with |
...el.eclipse.core/src/com/salesforce/bazel/eclipse/core/classpath/BazelClasspathContainer.java
Outdated
Show resolved
Hide resolved
...el.eclipse.core/src/com/salesforce/bazel/eclipse/core/classpath/BazelClasspathContainer.java
Outdated
Show resolved
Hide resolved
....core/src/com/salesforce/bazel/eclipse/core/classpath/BazelClasspathContainerSaveHelper.java
Outdated
Show resolved
Hide resolved
....core/src/com/salesforce/bazel/eclipse/core/classpath/BazelClasspathContainerSaveHelper.java
Outdated
Show resolved
Hide resolved
...orce.bazel.eclipse.core/src/com/salesforce/bazel/eclipse/core/classpath/ClasspathHolder.java
Outdated
Show resolved
Hide resolved
...pse.core/src/com/salesforce/bazel/eclipse/core/model/discovery/BaseProvisioningStrategy.java
Outdated
Show resolved
Hide resolved
...pse.core/src/com/salesforce/bazel/eclipse/core/model/discovery/JavaAspectsClasspathInfo.java
Outdated
Show resolved
Hide resolved
...pse.core/src/com/salesforce/bazel/eclipse/core/model/discovery/JavaAspectsClasspathInfo.java
Show resolved
Hide resolved
Co-authored-by: Gunnar Wagenknecht <gunnar@wagenknecht.org>
The work here it to add a
classpath_depth
option to the bazel project view. This configuration allows the classpath of the project to be reduced, where 1 is only the dependencies required for the targets imported to compile. Setting it less then 0 disables the filtering and the existing functionality to be used.This allows functionality similar to the IJ bazel plugin, which excludes transitives and provides a partial classpath. I would also like this concept be brought into IJ, but starting here