perf: Optimize PanelButton for improved performance and stability #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces several optimizations to the PanelButton, focusing on: - Reducing unnecessary UI updates by only updating label text when it changes. - Preventing potential memory leaks by properly destroying old ScrollingLabel instances before replacement. - Enhancing player switching behavior for a more predictable user experience. - Improving mouse event handling for middle and right clicks, and refining double-tap detection for left clicks.
winstonma
force-pushed
the
perf/panel-button-optimizations
branch
from
9d1645f to
a5cf11f
Compare
Recreate ScrollingLabel components instead of just updating text property to trigger proper width calculation and resize logic when content changes.
winstonma
force-pushed
the
perf/panel-button-optimizations
branch
from
a5cf11f to
488dab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces several optimizations to the PanelButton, focusing on: