Skip to content

Conversation

ChrisLauinger77
Copy link
Contributor

Introduces ESLint for code linting and a stale workflow to manage inactive issues and pull requests.

  • Adds an ESLint workflow to automatically scan code for potential issues.
  • Configures a stale workflow to automatically mark and close inactive issues and pull requests, improving issue tracker maintainability.
  • Removes jsconfig.json and global.d.ts

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ChrisLauinger77
Copy link
Contributor Author

ChrisLauinger77 commented Jun 30, 2025

This introduces the ESlint example from E.G.O. as well as workflow for stale issues.

I also deleted 3 unnecessary files.

@sakithb
also found a translation issue
grafik

Not really sure how to fix it elegantly - any idea ?

@ChrisLauinger77
Copy link
Contributor Author

ChrisLauinger77 commented Jun 30, 2025

ESlint with E.G.O. rules found a lot of stuff. I can have a look end on the week.

E.G.O eslint proposal
@ChrisLauinger77 ChrisLauinger77 force-pushed the ESlint_Translation branch 6 times, most recently from 0624c5e to c3be1dc Compare July 4, 2025 15:56
@ChrisLauinger77 ChrisLauinger77 force-pushed the ESlint_Translation branch 2 times, most recently from e07e991 to 95538f9 Compare July 4, 2025 17:02
@ChrisLauinger77 ChrisLauinger77 force-pushed the ESlint_Translation branch 2 times, most recently from 95538f9 to a45596f Compare July 4, 2025 17:43
Updates the POT creation date in multiple locale files.

Adds missing translations for "Artist", "Title", "Album", "Disc Number", and "Track Number" by introducing a new translation file. These strings are now extracted and included in the translation process.
@ChrisLauinger77
Copy link
Contributor Author

@sakithb 110 code scanning issues found with the E.G.O. proposed settings.
https://github.com/sakithb/media-controls/security/code-scanning?query=pr%3A210+is%3Aopen

I tried to fix
Require the use of === and !==
which is the most found - but it is not as easy as replace "==" by "===" or "!=" by "!==" ...

@ChrisLauinger77
Copy link
Contributor Author

I will not continue - I am frustrated :(

@sakithb
Copy link
Owner

sakithb commented Jul 15, 2025

@ChrisLauinger77 Would you like to take on maintaining the project fully?

@ChrisLauinger77
Copy link
Contributor Author

ChrisLauinger77 commented Jul 16, 2025

I wanted some years ago. Now I don't.
Feels like running in circles. Moved also on to another extension. Not using media-controls any more

@sakithb
Copy link
Owner

sakithb commented Jul 16, 2025

I don't use GNOME any more, so I don't get to use / develop / test the extension easily anymore. I am hoping someone forks this or takes over maintenance. Anyway I will put up a banner in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants