stopped haxe complaining about deprecated @:extern stuff #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saharan
reviewed
May 18, 2025
Comment on lines
-124
to
+123
| field.meta.push({ | ||
| name: ":extern", | ||
| pos: U.pos() | ||
| }); | ||
| Context.getLocalClass().get().isExtern = true; | ||
|
|
There was a problem hiding this comment.
I think this will change the behavior... 🤔
The removed lines add extern metadata to variables that should finally be wiped, like foo:IVec3 which will be decomposed into fooX, fooY, and fooZ.
On the other hand I think Context.getLocalClass().get() returns the current class that is to be built, so setting it extern may wipe the entire class, but is not working somehow if it isn't causing compiler errors?
Haxe is complaining about the metadata because the metadata @:extern has been promoted into an attribute extern, so adding the attribute properly may be the right way. I need to look into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes it complaining about using the @:extern metadata! I've checked it against the previous outputs and it looks like it's the same!