remove the entire notion of sticky routing from the conat router #8622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent optionally; support running multiple changefeed servers in the main hub process for testing/dev purposes. - with this the requests get randomly assigned to the available servers; no need for consistency for this application.
- deleted all multi persist server test since it would be a lot of work to redo, due to really needing to run as a cluster. TODO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was basically the one and only complicated "innovation" that I added to NATS when I reimplemented the entire NATS pub/sub model. It turns out that it adds a lot of complexity to the code, might have a bug, and is not necessary for how we actually use pub/sub. So I'm deleting it entirely, which greatly simplifies the routers.