use filename when creating file via extension dropdown

[enjeck]

Description

Fixes #7385

Before

2024-09-13_06-30-06.mp4

After

2024-09-13_07-38-36.mp4

Checklist:

• Testing instructions are provided, if not obvious
• Release instructions are provided, if not obvious

[enjeck]

cc @novoselt

[haraldschilly]

hmm, I see, I wonder as well why the state isn't updated properly? My second thought is, is that dropdown-create activity used elsewhere as well, and hence there might be a problem overwriting the filename.

[enjeck]

hmm, I see, I wonder as well why the state isn't updated properly? My second thought is, is that dropdown-create activity used elsewhere as well, and hence there might be a problem overwriting the filename.

I thought so too, that the dropdown might be overwriting it. But couldn't find any references there. I must be missing something

[williamstein]

My guess is that this bug is because filename is in a closure (i.e., a function). filename is updated in the component, but the copy of the function createFile (etc.) that is actually called on submit is an older copy that has an old version of filename.

All this code used to be coffeescript with classes, and we migrated it over the years to typescript with functional components. This is one of those subtle traps that comes up in such migration. Often we leave the class methods as nested functions in the functional component (instead of further refactoring the code), which can cause bugs.

A fix is to get the value using some sort of reference, which is basically what you did.

[haraldschilly]

@enjeck thank you for the PR, but we need a CLA (contributor license agreement) for all code contributions on file. It's just a standard document to clarify it can be used by CoCalc and the company behind. You do not have an email address on your github profile and I don't know how to contact you. So, please reach out to me ( hsy@cocalc.com ) and I'll send you a form.