Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 9, 2025

This PR removes all remaining artifacts from an old splash screen implementation that was no longer being used in the main game flow.

Changes Made

  • Removed ui/splash.gd - Old splash screen script that was misleadingly named
  • Removed ui/splash.gd.uid - Associated UID file for the old splash script
  • Created ui/credits.gd - New properly named script for credits functionality
  • Updated ui/credits.tscn - Now references the correct credits.gd script instead of the old splash script
  • Renamed functions - Changed exit_splash() to exit_credits() for semantic clarity

Context

The repository had leftover files from an old splash screen implementation. The splash.gd script was actually being used by the credits screen (credits.tscn) but retained the old splash-related naming, which was confusing and misleading.

The main game flow already bypassed any splash screen (project starts directly with main.tscn), so these were truly just leftovers that needed cleanup.

Verification

  • ✅ No files named *splash* remain in the repository
  • ✅ No textual references to "splash" exist in any code files
  • ✅ Credits screen functionality remains intact
  • ✅ Credits still display for 10 seconds or until user input, then return to main scene

Fixes #1.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI assigned Copilot and saebyn Jun 9, 2025
@Copilot Copilot AI changed the title [WIP] Remove leftovers of old splash screen Remove leftovers of old splash screen Jun 9, 2025
@Copilot Copilot AI requested a review from saebyn June 9, 2025 01:16
Copilot finished work on behalf of saebyn June 9, 2025 01:17
Co-authored-by: saebyn <185030+saebyn@users.noreply.github.com>
@saebyn saebyn marked this pull request as ready for review June 9, 2025 01:18
@Copilot Copilot AI review requested due to automatic review settings June 9, 2025 01:18
@saebyn saebyn merged commit 3e0c46b into main Jun 9, 2025
3 checks passed
@saebyn saebyn deleted the copilot/fix-1 branch June 9, 2025 01:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes leftover splash screen artifacts and properly renames and hooks up the credits functionality.

  • Deleted outdated splash script and its UID file
  • Updated scene to reference the new credits.gd script
  • Renamed exit_splash() to exit_credits() for semantic clarity

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
ui/splash.gd.uid Removed obsolete splash screen UID file
ui/credits.tscn Updated script reference from splash.gd to credits.gd
ui/credits.gd Renamed exit_splash() to exit_credits() and updated calls
Comments suppressed due to low confidence (1)

ui/credits.gd:14

  • Currently the keyboard input branch exits on any key event, including key release. To match the mouse branch, wrap this call in if event.is_pressed(): so it only triggers on key press.
exit_credits()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove leftovers of old splash screen

2 participants