show timestamp when moving mouse over timeline #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR implements a feature to display a timestamp when hovering over the timeline, addressing issue #89. Key changes include:
- Adding Storybook stories for VideoPlayerProgressBar and VideoPlayer components.
- Enhancing the Timeline component with improved drag state handling and a new hover state to show formatted timestamps.
- Updating the Timeline story to include an onItemSelect action for additional interactivity.
Reviewed Changes
| File | Description |
|---|---|
| src/components/atoms/VideoPlayerProgressBar.stories.tsx | Introduces Storybook stories for the VideoPlayerProgressBar component. |
| src/components/molecules/VideoPlayer.stories.tsx | Adds a new Storybook story for the VideoPlayer component. |
| src/components/organisms/Timeline.tsx | Implements hover state and drag behavior improvements, with timestamp display on mouse hover. |
| src/components/organisms/Timeline.stories.tsx | Updates the Timeline story with a new onItemSelect action. |
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89