-
Notifications
You must be signed in to change notification settings - Fork 0
add cut selection to video editor page #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb0732a
to
8c1b967
Compare
…imeline component
…illiseconds instead of seconds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 17 changed files in this pull request and generated no comments.
Files not reviewed (11)
- src/components/molecules/SelectedCutsDialog.tsx: Evaluated as low risk
- src/components/molecules/TimelineElement.tsx: Evaluated as low risk
- src/components/atoms/Button.tsx: Evaluated as low risk
- src/components/molecules/ClipSelectionDialog.stories.tsx: Evaluated as low risk
- src/utils/timeline.ts: Evaluated as low risk
- src/components/atoms/VideoPlayerControls.tsx: Evaluated as low risk
- src/components/pages/VideoSelectionPage.stories.tsx: Evaluated as low risk
- src/components/organisms/Timeline.tsx: Evaluated as low risk
- src/components/atoms/TimeSegmentMarker.tsx: Evaluated as low risk
- src/components/atoms/IconButton.tsx: Evaluated as low risk
- src/components/molecules/VideoPlayer.tsx: Evaluated as low risk
Comments suppressed due to low confidence (4)
src/components/molecules/ClipSelectionDialog.tsx:49
- [nitpick] Consider using a TypeScript enum for the direction parameter to improve type safety and readability.
const handleReorder = (index: number, direction: "up" | "down") => {
src/components/molecules/TimeTable.tsx:81
- [nitpick] The class names used in the Button component should be consistent and follow the project's naming conventions.
<Button className="mx-2 rounded text-white bg-green-500 dark:bg-green-600 dark:text-white">
src/components/molecules/TimeTable.tsx:88
- [nitpick] The class names used in the Button component should be consistent and follow the project's naming conventions.
<Button className="mx-2 rounded bg-blue-500 text-white dark:!bg-blue-600 dark:text-white" onClick={() => onClip?.(row)}>
src/components/molecules/TimeTable.tsx:95
- [nitpick] The class names used in the Button component should be consistent and follow the project's naming conventions.
<Button className="rounded bg-red-500 text-white dark:bg-red-600 dark:text-white">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61