Skip to content

Conversation

@saebyn
Copy link
Owner

@saebyn saebyn commented Mar 20, 2025

Closes saebyn/glowing-telegram#409
This pull request introduces a new EpisodesListButton component and refactors the useBulkEpisodeCreate hook to improve its functionality and error handling. Additionally, there are updates to various files to integrate the new button and enhance the codebase.

New Component:

Hook Refactoring:

Integration of New Component:

Codebase Enhancements:

@Copilot Copilot AI review requested due to automatic review settings March 20, 2025 23:33
@saebyn saebyn self-assigned this Mar 20, 2025
@saebyn saebyn enabled auto-merge (rebase) March 20, 2025 23:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new EpisodesListButton component for navigating to the episodes list and refactors the useBulkEpisodeCreate hook to improve its type definitions, error handling, and validation logic. It also integrates the new button into stream editing and showing views and updates import paths for consistency.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/components/atoms/EpisodesListButton.tsx New component to navigate to the episodes list with appropriate filters.
src/hooks/useBulkEpisodeCreate.ts Refactored hook with improved type safety, error handling, and added validation functions.
src/resources/streams/Edit.tsx Integrated the new EpisodesListButton component and added an EditorButton; note potential duplicate ListButton.
src/resources/streams/Show.tsx Replaced the old episodes button with the new EpisodesListButton.
src/resources/episodes/List.tsx Updated import path for RenderEpisodesButton to reflect its new location.
Comments suppressed due to low confidence (1)

src/hooks/useBulkEpisodeCreate.ts:97

  • The notify function is used without an import or definition. Consider importing it (e.g., from 'react-admin' using the useNotify hook) to ensure it works correctly.
        notify('gtk.bulk_create_episodes.success', {

@saebyn saebyn merged commit 909a052 into main Mar 20, 2025
3 checks passed
@saebyn saebyn deleted the saebyn/issue409 branch March 20, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

not validating start_time and other key values on bulk episode creation

1 participant