Support ignoring URL params #90 #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your submission, but i think you did it wrong - not in terms of code, but in logic - this flag strips params only from starting url, but not from crawled ones so it will not work as expected. best regards, |
|
Hello, and thank you for the review. I believe I've now corrected the logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented a new feature by adding a flag called ignore-query to the project. This flag strips query parameters from the URI during scraping. To achieve this, I utilized the NormalizeURL function in the utils.go file to ensure consistency in URL normalization.
I would love to hear your feedback on this implementation and contribute more to the project!
Best regards,
Stefanos