Add opts to upload
#36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warmwaffles
force-pushed
the
add-opts-to-upload
branch
2 times, most recently
from
0a95cc6 to
acc84ef
Compare
rzane
reviewed
Apr 4, 2025
| end | ||
|
|
||
| def upload(store, source, key) do | ||
| def upload(store, source, key, opts) do |
Owner
There was a problem hiding this comment.
If we add this as a required positional argument, wouldn't that be a breaking change? Should we preserve upload/3?
Contributor
Author
There was a problem hiding this comment.
It won't be. The default opt \\ [] will fill that in.
rzane
reviewed
Apr 4, 2025
|
|
||
| def upload(store, source, key) do | ||
| FileStore.upload(store.__next__, source, put_prefix(key, store)) | ||
| def upload(store, source, key, opts) do |
Contributor
Author
There was a problem hiding this comment.
It will break some what, but a compiler error on the down stream consumer will be returned. They will be notified that they need to fill the rest of it in.
Contributor
Author
|
Side note, I don't use these middleware things. I don't know if anyone actually does and if it is even that important to have support for them. |
I've found the need to pass along the content type and disposition to Amazon in order to have the correct metadata set on the object. I did not want to load the entire binary into memory to call `write`. Instead, I would like to stream the file from disk.
warmwaffles
force-pushed
the
add-opts-to-upload
branch
from
acc84ef to
0bb4cda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found the need to pass along the content type and disposition to Amazon in order to have the correct metadata set on the object. I did not want to load the entire binary into memory to call
write. Instead, I would like to stream the file from disk.This also expands the typespecs defined. I've opted for
String.t()in places where I feel the developer should know that it is intended to be a human readable value. Even though under the hoodbinary()andString.t()are the same thing, it's still a good signal to the reader.I realize this will conflict with #34, but I am going to rework that one a bit.