Skip to content

WIP: branch working on adding support for an external display. #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

WIP: branch working on adding support for an external display. #178

wants to merge 6 commits into from

Conversation

DaveDavenport
Copy link
Collaborator

No description provided.

@DaveDavenport DaveDavenport marked this pull request as draft January 29, 2023 11:09
@rvdbreemen rvdbreemen self-requested a review January 29, 2023 12:02
@rvdbreemen rvdbreemen added this to the 0.11.0 milestone Jan 29, 2023
@rvdbreemen
Copy link
Owner

Linked to Issue #152

@DaveDavenport DaveDavenport mentioned this pull request Jan 29, 2023
Open
rvdbreemen
rvdbreemen approved these changes Jan 29, 2023
View reviewed changes
Copy link
Owner

@rvdbreemen rvdbreemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way you do this, nice an clean in a class that handles everything. Great for readability of the main code. In wonder why you call it 'tick' and not just 'update'.

@rvdbreemen rvdbreemen added the enhancement New feature or request label Jan 29, 2023
@DaveDavenport
Copy link
Collaborator Author

tick is often used for a periodic updating thing.. (f.e. systick timer)
We could also change it to 'loop()' that is often used in arduino?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvdbreemen rvdbreemen rvdbreemen approved these changes

Assignees

@DaveDavenport DaveDavenport

Labels

enhancement New feature or request

Projects

OTGW ESP firmware backlog
Status: In Progress

Milestone

0.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@DaveDavenport @rvdbreemen