feat: add messageArchive #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyjeileen
requested review from
Shiti,
florenceloi and
milliondreams
as code owners
Shiti
requested changes
Jun 13, 2025
Comment on lines
18
to
19
| /** Previous chat messages */ | ||
| receivedMessages: Message[] |
There was a problem hiding this comment.
Both Dev and end user experience would be better if expected a method fetchOldMessages:() =>Promise<Message[]> and an optional loadingIcon. It will make it easier for developers to define and provide custom fetch logic. The component could show the loading icon until the response is received.
| infoMessage?: string | ||
| } | ||
|
|
||
| function getCombinedMessages( |
There was a problem hiding this comment.
This looks like duplicate code from MessageSpace. We could avoid that by using Composition or Higher-Order Components.
Shiti
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
messageArchivecomponent to show messages without ws connectionVideo