Skip to content

fix: sent chatCompletion message correctly #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Conversation

lyjeileen
Copy link
Collaborator

Change

  • sent chatCompletion message correctly
    • toChatRequest was applied twice for multimodalInput — once in baseInput, and once in multimodalInput. I removed toChatRequest from baseInput and kept the conversion only in multimodalInput and textInput.
  • update tests and storybook
    • The way we displayed textInput in Storybook was rendering the baseInput component, instead of textInput. I now render textInput directly and reuse the argType descriptions in both textInput and multimodalInput.

Screenshots

Before

Screenshot 2025-04-08 at 1 15 53 PM Screenshot 2025-04-08 at 1 20 25 PM

After

Screenshot 2025-04-08 at 1 16 21 PM Screenshot 2025-04-08 at 1 18 16 PM

@lyjeileen lyjeileen merged commit 55256cd into rustic-ai:main Apr 8, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants