Skip to content

Install codecov.io uploader into container #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

roypat
Copy link
Member

@roypat roypat commented May 9, 2025

Needed for rust-vmm/community#183, to replace out homegrown, file-based coverage checks with codecov.io.

Summary of the PR

Please summarize here why the changes in this PR are needed.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@roypat roypat changed the title Install codecov.io uploaded into container Install codecov.io uploader into container May 9, 2025
Needed for rust-vmm/community#183, to replace
out homegrown, file-based coverage checks with codecov.io.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@roypat roypat force-pushed the codecov-uploader branch from b22e3bf to c6771f9 Compare May 9, 2025 10:41
Copy link
Member

@RuoqingHe RuoqingHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @roypat! I will work out codecov on RISC-V and come back later, let's get the wheels turning first 😉

@roypat
Copy link
Member Author

roypat commented May 12, 2025

Looks good to me, thanks @roypat! I will work out codecov on RISC-V and come back later, let's get the wheels turning first 😉

Thanks! I had a cursory glance around the codecov website, but it seems like they don't have a native riscv uploader :/

@roypat roypat merged commit 8a7b5ba into rust-vmm:main May 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants