build_container: Install rsync in image #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rsync` is required for installing kernel headers, which will be used in `seccompiler` crate to generate syscall tables. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
requested review from
andreeaflorescu,
lauralt,
stefano-garzarella,
stsquad,
roypat,
ShadowCurse and
TimePrinciple
as code owners
|
@stefano-garzarella @roypat PTAL when convenient 🙂 |
stefano-garzarella
approved these changes
Mar 6, 2025
roypat
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
rsyncis required for installing kernel headers, which will be used inseccompilercrate to generate syscall tables.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.