Skip to content

Conversation

@phil-opp
Copy link
Member

@phil-opp phil-opp commented Oct 7, 2024

Make GDT::append and GDT::push const by default. The const_fn feature is now a no-op.

Fixes #499

@phil-opp phil-opp requested a review from Freax13 October 7, 2024 18:45
@phil-opp phil-opp marked this pull request as ready for review October 7, 2024 18:45
@phil-opp phil-opp mentioned this pull request Oct 7, 2024
Make `GDT::append` and `GDT::push` `const` by default. The `const_fn` feature is now a no-op.
@phil-opp phil-opp force-pushed the remove-const_mut_refs-feature branch from 7278462 to d3e28e9 Compare October 7, 2024 19:55
Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :shipit:

@Freax13 Freax13 merged commit 8adb26d into master Oct 8, 2024
10 of 13 checks passed
@Freax13 Freax13 deleted the remove-const_mut_refs-feature branch October 8, 2024 06:15
@Freax13
Copy link
Member

Freax13 commented Oct 8, 2024

I briefly had to uncheck the "Do not allow bypassing the above settings" settings to merge this PR. I re-enabled them after merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI failure because of stabilized const_mut_refs feature

3 participants