Skip to content

Extract check-commits handler trigger logic and add tests for it #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2025

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Jul 12, 2025

This PR extracts the check-commits super-handler trigger logic and add tests for it, so we can make sure it doesn't regress accidentally.

Related to #2110

@Urgau Urgau requested a review from Kobzol July 12, 2025 10:45
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is very nice. Left two nits, but feel free to merge as you want.

@Urgau Urgau force-pushed the test-check-commits-trigger branch from ce522d6 to 8d94d24 Compare July 12, 2025 11:36
@Urgau Urgau added this pull request to the merge queue Jul 12, 2025
Merged via the queue into rust-lang:master with commit 0012786 Jul 12, 2025
3 checks passed
@Urgau Urgau deleted the test-check-commits-trigger branch July 12, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants