Also support concern resolve to resolve concerns
#2090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Jun 30, 2025
| toks.next_token()?; | ||
|
|
||
| if action == "concern" { |
There was a problem hiding this comment.
Hmm, what is someone tries to create a concern (sentence) that starts with the word "resolve"? 😆 Well, probably a too niche of an edge-case.
There was a problem hiding this comment.
I asked jieyouxu about it and I was told "that seems somewhat... strange xD", so left it. We can always add it later.
There was a problem hiding this comment.
Yeah, I thought that was even more niche, and maybe more of a "well don't do that" xD
Kobzol
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an alias to
@bot resolvein the form of@bot concern resolve, this adds a parallel with@bot note remove.This came up here rust-lang/rust#142824 (comment).
cc @jieyouxu