Skip to content

Add more blocking CI checks to rustc-perf #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jun 30, 2025

The CI didn't block on compile benchmarks failing, which is annoying (rust-lang/rustc-perf#2176).

Copy link

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/rustc-perf':
      Branch Protections:
          master
            Required Checks: ["Database Check", "Test and deploy", "Test on Windows"] => ["Database Check", "Test and deploy", "Test benchmarks", "Test on Windows", "Test runtime benchmarks"]

@Kobzol Kobzol requested a review from marcoieni July 14, 2025 08:49
@marcoieni marcoieni added this pull request to the merge queue Jul 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 14, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Jul 14, 2025

Looks like a spurious error.

@marcoieni marcoieni added this pull request to the merge queue Jul 14, 2025
Merged via the queue into rust-lang:master with commit 87cdb5f Jul 14, 2025
3 checks passed
@Kobzol Kobzol deleted the rustc-perf-ci-checks branch July 14, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants