Skip to content

let anyone in the org approve PRs to Forge #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −12
Open

let anyone in the org approve PRs to Forge #1839

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6ef4c5
let anyone in the org approve PRs to Forge
jyn514 May 23, 2025
f07eac0
downgrade permissions to "write"
jyn514 May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions repos/rust-lang/rust-forge.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,7 @@ homepage = "https://forge.rust-lang.org/"
bots = ["rustbot"]

[access.teams]
community = "maintain"
compiler = "maintain"
crates-io = "maintain"
docs-rs = "maintain"
infra = "maintain"
lang = "maintain"
lang-ops = "maintain"
leadership-council = "maintain"
libs = "maintain"
libs-api = "maintain"
edition = "maintain"
release = "maintain"
triagebot = "maintain"
all = "maintain"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also change this to write, especially now that we give access to more people. I don't think that maintain is needed for Forge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference between the two?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit hard to summarize 😅 Here's a table: https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/managing-repository-roles/repository-roles-for-an-organization

With maintain, you can modify wikis and do a bunch of additional things, but for modifying issues/labels and merging/approving PRs, write should be enough.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh interesting, the main difference I see is that "maintain" lets you push to protected branches. I suppose we were already letting people bypass review, it's just that nobody noticed lol.

i'll change this to "write".


[[branch-protections]]
pattern = "master"