-
Notifications
You must be signed in to change notification settings - Fork 298
loongarch: Use unified data types for SIMD intrinsics #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Although type aliases won't break the build, they will trigger clippy wanrings. If the user's CI treats warnings as errors, this could cause the CI to fail.
|
seeing that it is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re. the transmute warning, that is fine, but it's probably nicest for users to #[allow]
the lint (or even #[expect]
if you can make that work)
241e547
to
24ee4b0
Compare
a gentle ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The technical changes look good to me, I've left some notes on the docs. Those are user-facing, so I've been a bit nit-picky there.
7ad929b
to
aef5960
Compare
aef5960
to
4828d5c
Compare
r? @folkertdev |
Suggested by @sayantn