Skip to content

Use simd_extract! macro instead of calling simd_extract directly #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clarfonthey
Copy link

@clarfonthey clarfonthey commented Jun 30, 2025

Was poking at this due to the desire to potentially change this intrinsic to use a const generic. The macro has been presumably updated to allow an explicit type parameter after this change was made, so, this uses that instead to allow potentially updating the calling convention later.

Side note: while looking into this, it feels unlikely we'll be able to do that anyway due to the fact that casting types is not allowed in generic constants, and some intrinsics have already stabilised i32 const generics over u32 ones. But this change felt okay anyway, so, I wanted to offer it as a PR.

@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@clarfonthey clarfonthey changed the title Use simd_extract! macro instead of calling simd_extract directly Use simd_extract! macro instead of calling simd_extract directly Jun 30, 2025
@clarfonthey
Copy link
Author

Side note: ARM test failures despite not modifying any ARM code indicate something spurious. I don't think my change is the issue; it should literally not affect anything besides making some not-fully-qualified paths fully-qualified.

@sayantn
Copy link
Contributor

sayantn commented Jun 30, 2025

yeah, it is a rustc bug. The fix is in the process of being merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants