Use simd_extract!
macro instead of calling simd_extract
directly
#1841
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was poking at this due to the desire to potentially change this intrinsic to use a const generic. The macro has been presumably updated to allow an explicit type parameter after this change was made, so, this uses that instead to allow potentially updating the calling convention later.
Side note: while looking into this, it feels unlikely we'll be able to do that anyway due to the fact that casting types is not allowed in generic constants, and some intrinsics have already stabilised
i32
const generics overu32
ones. But this change felt okay anyway, so, I wanted to offer it as a PR.