Skip to content

Add support for Windows Registered I/O #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DBLouis
Copy link

@DBLouis DBLouis commented Jul 19, 2025

This allows to create socket with the WSA_FLAG_REGISTERED_IO flag.

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change then it LGTM

@Thomasdezeeuw
Copy link
Collaborator

Should I also simplify it for the existing custom flag?

No, because that is used with the all feature being enabled, that's the reason the code is written the way it is.

@DBLouis
Copy link
Author

DBLouis commented Jul 23, 2025

Should I also simplify it for the existing custom flag?

No, because that is used with the all feature being enabled, that's the reason the code is written the way it is.

I don't get it sorry. Also I put the new function with the all feature flag too, should I remove it?

@Thomasdezeeuw
Copy link
Collaborator

@DBLouis you need to revert all changes to _no_inherit and no_inherit. We do it this way because no_inherit should only be public if the all feature is set. However, internally we also use the function, so we added _no_inherit that is always available.

@DBLouis
Copy link
Author

DBLouis commented Jul 24, 2025

That makes sense. So I revert the changes for no_inherit, but for registered-io I keep only one function. Should it be feature gated though? It is a windows only flag and a bit niche.

@Thomasdezeeuw
Copy link
Collaborator

Should it be feature gated though? It is a windows only flag and a bit niche.

That's exactly why it should be feature gated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants