Skip to content

Fixed some clippy warnings. #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Fixed some clippy warnings. #716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions build_system/src/abi_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,16 @@ fn show_usage() {

pub fn run() -> Result<(), String> {
let mut args = std::env::args().skip(2);
// FractalFir: In the future, I'd like to add some more subcommands / options.
// So, this loop ought to stay for that purpose. It should also stay as a while loop(to parse args)
#[allow(clippy::never_loop, clippy::while_let_on_iterator)]
while let Some(arg) = args.next() {
match arg.as_str() {
"--help" => {
show_usage();
return Ok(());
}
_ => return Err(format!("Unknown option {}", arg)),
_ => return Err(format!("Unknown option {arg:?}")),
}
}
// Ensure that we have a cloned version of abi-cafe on hand.
Expand Down Expand Up @@ -56,7 +59,7 @@ pub fn run() -> Result<(), String> {
&"c_calls_cg_gcc",
];
// Run ABI cafe.
run_command_with_output(cmd, Some(&Path::new("clones/abi-cafe")))?;
run_command_with_output(cmd, Some(Path::new("clones/abi-cafe")))?;

Ok(())
}