Do not compile extended tools in bootstrap benchmark #2158
Conversation
| @@ -98,6 +98,9 @@ async fn record( | |||
| "build.cargo={}", | |||
| toolchain.components.cargo.to_str().unwrap() | |||
| )) | |||
| // Do not compile all default tools | |||
| .arg("--set") | |||
| .arg("build.extended=false") | |||
There was a problem hiding this comment.
....why is this on by default? It's literally extended :)
But seems fine.
There was a problem hiding this comment.
rustc-perf runs configure, which creates a config file based on the dist profile. And dist uses extended = true, which I guess makes sense for it.
There was a problem hiding this comment.
Hm, the goal of the bootstrap timing is really more focused on rustc devs IMO, not distros, so we might want to change that to compiler or so... though maybe this is enough in practice.
There was a problem hiding this comment.
Hm², the dist profile doesn't download-ci-llvm, so I hope we're not building llvm on the collector.
There was a problem hiding this comment.
We enable download CI LLVM a few lines before, don't worry 😅
I really don't think that we have to compile things like
llvm-bitcode-linkerandwasm-component-ldin the bootstrap benchmark. Especially the compilation is performed with-j1, so compiling tens of dependencies that these crates have is quite painful.This should speed up the bootstrap build by a couple of minutes, I think.