Skip to content

Feat; Create new table for collector configuration #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions database/schema.md
Original file line number Diff line number Diff line change
Expand Up @@ -258,3 +258,15 @@ aid benchmark error
---------- --- -----
1 syn-1.0.89 Failed to compile...
```

### collector_config

Information about the collector; it's target architecture, when it was added, whether it is active and when it last had activity denoted by `last_heartbeat_at`.

```
sqlite> SELECT * FROM collector_config;

id target date_added last_heartbeat_at benchmark_set is_active
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update this with name? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--------- ------------------------- ------------- ---------------- --------- -------
ea1f4e... aarch64-unknown-linux-gnu 2025-06-11... 2025-06-12 17... cea1bc... 0
```
11 changes: 11 additions & 0 deletions database/src/pool/postgres.rs
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,17 @@ static MIGRATIONS: &[&str] = &[
alter table pstat_series drop constraint test_case;
alter table pstat_series add constraint test_case UNIQUE(crate, profile, scenario, backend, target, metric);
"#,
r#"CREATE EXTENSION IF NOT EXISTS "uuid-ossp";"#,
r#"
CREATE TABLE IF NOT EXISTS collector_config (
id UUID PRIMARY KEY,
Copy link
Contributor

@Kobzol Kobzol Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have probably max. 4? collectors in the near future 😅 So I think that UUIDs are overkill. My experience with messing with Postgres extensions is that it can go wrong, I would prefer to avoid this and just use good ol' autoincremented IDs.

On the other hand, I'd like to assign human-readable names to the collectors, for easier debugging. So please add a name TEXT NOT NULL column, thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target TEXT NOT NULL,
date_added TIMESTAMPTZ DEFAULT NOW() NOT NULL,
last_heartbeat_at TIMESTAMPTZ,
benchmark_set UUID NOT NULL,
is_active BOOLEAN DEFAULT FALSE NOT NULL
);
"#,
];

#[async_trait::async_trait]
Expand Down
12 changes: 12 additions & 0 deletions database/src/pool/sqlite.rs
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,18 @@ static MIGRATIONS: &[Migration] = &[
alter table pstat_series_with_target rename to pstat_series;
"#,
),
Migration::without_foreign_key_constraints(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should "delay" the tables on the SQLite side until we finish the Postgres implementation? Just to potentially avoid needless migrations (i.e. Postgres could serve as a "testbed" for the DB). I'm not even sure if we'll ever need this table on the SQLite side, tbh.

r#"
CREATE TABLE IF NOT EXISTS collector_config (
id TEXT PRIMARY KEY,
target TEXT NOT NULL,
date_added TIMESTAMP DEFAULT CURRENT_TIMESTAMP NOT NULL,
last_heartbeat_at TIMESTAMP,
benchmark_set TEXT NOT NULL,
is_active BOOLEAN DEFAULT FALSE NOT NULL
);
"#,
),
];

#[async_trait::async_trait]
Expand Down
Loading