Skip to content

Fix Clippy benchmarks #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2025
Merged

Fix Clippy benchmarks #2154

merged 3 commits into from
Jun 10, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 10, 2025

Turns out that the Clippy benchmarks weren't actually running clippy, but pretty much were just doing debug builds 🤦‍♂️

@Kobzol Kobzol requested a review from nnethercote June 10, 2025 07:11
nnethercote
nnethercote approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, it works.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 10, 2025

Clippy now does more work than check, which is expected:
image

And it does something different than before (on master), when it really was just debug 🤦
image

image

@Kobzol Kobzol merged commit 2e743a6 into rust-lang:master Jun 10, 2025
11 checks passed
@Kobzol Kobzol deleted the clippy-fix branch June 10, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kobzol @nnethercote