Add time reference and tracking info for trait system refactor #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smanilov
commented
May 23, 2025
| [const_evaluatable]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/type.ClauseKind.html#variant.ConstEvaluatable |
There was a problem hiding this comment.
Not sure what's the diff here. Perhaps there was no NL at EOF.
tshepang
reviewed
May 23, 2025
| @@ -166,7 +166,9 @@ In this example: | |||
|
|
|||
| When interfacing with the type system it will often be the case that it's necessary to request a type be normalized. There are a number of different entry points to the underlying normalization logic and each entry point should only be used in specific parts of the compiler. | |||
|
|
|||
| An additional complication is that the compiler is currently undergoing a transition from the old trait solver to the new trait solver. As part of this transition our approach to normalization in the compiler has changed somewhat significantly, resulting in some normalization entry points being "old solver only" slated for removal in the long-term once the new solver has stabilized. | |||
| An additional complication is that the compiler is currently (as of May 2025) undergoing a transition from the old trait solver to the new trait solver. | |||
There was a problem hiding this comment.
you can choose to hide the date using notation in [this section], and it will appear in a monthly issue showing things that need refreshing (example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I inferred the tracking info myself. If you review this PR, please confirm that it's correct. Is such info useful in the docs in your opinion?