Skip to content

[Place 2.0] Convert Place's projection to a boxed slice #63420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 13, 2019
+1,590 −1,776
Merged

[Place 2.0] Convert Place's projection to a boxed slice #63420

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e9c4114
Convert Place's projection to a boxed slice
spastorino Jul 29, 2019
7efee8d
Use rposition to find the position of an elem
spastorino Aug 24, 2019
b04e6c7
Make move_path_children_matching closure take a PlaceElem instead of …
spastorino Aug 24, 2019
e73d189
Use slice patterns to match projection base
spastorino Aug 25, 2019
87420cd
Make Place Boxed on Statement to reduce size from 64 bytes to 32 bytes
spastorino Sep 11, 2019
9c0bbe0
Use fold
spastorino Sep 12, 2019
232a4a2
Destructure instead of using split_at
spastorino Sep 12, 2019
07a706e
Avoid math and use patterns to grab projection base
spastorino Sep 12, 2019
98edaea
Fix style in comments
spastorino Sep 12, 2019
6ffc20f
Use if let here
spastorino Sep 12, 2019
28db2c9
Make all projection base names be proj_base
spastorino Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/librustc_mir/transform/instcombine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ impl<'tcx> MutVisitor<'tcx> for InstCombineVisitor<'tcx> {
ref mut base,
projection: ref mut projection @ box [.., _],
}) => {
let (proj_l, proj_r) = projection.split_at(projection.len() - 1);
let [proj_l @ .., proj_r] = projection;

let place = Place {
// Replace with dummy
Expand Down