Skip to content

Suppress unused_parens for labeled break #147546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Suppress unused_parens for labeled break #147546

wants to merge 1 commit into from
+32 −1

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Oct 10, 2025 •
edited by rustbot
Loading

Fixes #147542

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 10, 2025

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jackh726
jackh726 approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, but please add a comment to the test on what it's testing (also, is there not a better spot than just in tests/ui/lint?

View changes since this review

@chenyukang chenyukang force-pushed the yukang-fix-break-label-147542 branch from c5f410e to d658bcf Compare October 14, 2025 04:33
@chenyukang
Copy link
Member Author

Added comment and moved test to tests/ui/lint/unused.

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented Oct 14, 2025

📌 Commit d658bcf has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 14, 2025
@Zalathar
Rollup merge of rust-lang#147546 - chenyukang:yukang-fix-break-label-…
a49246a 
…147542, r=jackh726

Suppress unused_parens for labeled break

Fixes rust-lang#147542
@Zalathar Zalathar mentioned this pull request Oct 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackh726 jackh726 jackh726 approved these changes

Assignees

@jackh726 jackh726

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Labeled break lint collides with unused parens lint

4 participants

@chenyukang @rustbot @bors @jackh726