-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Do not lint private-in-public for RPITIT #144098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Yes, it is actually desirable, and #143357 was a bugfix. |
Yeah, let's "fix" this and then re-crater it. We should be able to detect crater fallout by just diffing the changes from 9c3064e and its parent. @craterbot run mode=check-only start=master#e9182f195b8505c87c4bd055b9f6e114ccda0981 end=master#9c3064e131f4939cc95a29bb11413c49bbda1491 |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
In the mean time though, let's get this merged. @bors r+ |
#144139 to make sure we don't forget this |
Fixes the hard error introduced by #143357
Instead of trying to accept this hard error directly, this PR copies tests from #144020 and removes the error.
If the behaviour is actually desirable, the second commit can be reverted with a proper crater run.
cc #143531 for bookkeeping
r? @compiler-errors