Skip to content

Do not lint private-in-public for RPITIT #144098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cjgillot
Copy link
Contributor

Fixes the hard error introduced by #143357

Instead of trying to accept this hard error directly, this PR copies tests from #144020 and removes the error.

If the behaviour is actually desirable, the second commit can be reverted with a proper crater run.

cc #143531 for bookkeeping

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 17, 2025
@petrochenkov
Copy link
Contributor

If the behaviour is actually desirable, the second commit can be reverted with a proper crater run.

Yes, it is actually desirable, and #143357 was a bugfix.

@compiler-errors
Copy link
Member

Yeah, let's "fix" this and then re-crater it.

We should be able to detect crater fallout by just diffing the changes from 9c3064e and its parent.

@craterbot run mode=check-only start=master#e9182f195b8505c87c4bd055b9f6e114ccda0981 end=master#9c3064e131f4939cc95a29bb11413c49bbda1491

@craterbot
Copy link
Collaborator

👌 Experiment pr-144098 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2025
@compiler-errors
Copy link
Member

In the mean time though, let's get this merged.

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 18, 2025

📌 Commit c004a96 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jul 18, 2025
@compiler-errors
Copy link
Member

#144139 to make sure we don't forget this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants