Skip to content

Rehome 35 tests/ui/issues/ tests to other subdirectories under tests/ui/ #144089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Jul 17, 2025

#143902 divided into smaller, easier to review chunks.

Part of #133895

Methodology:

  1. Refer to the previously written tests/ui/SUMMARY.md
  2. Find an appropriate category for the test, using the original issue thread and the test contents.
  3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
  4. Rename the tests to make their purpose clearer

The URL addition at the end, as well as moving around the auxiliary files and editing the stderr files with the new filename, were done using a Python script.

Inspired by the methodology that @Kivooeo was using.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

There are changes to the tidy tool.

cc @jieyouxu

@Oneirical Oneirical force-pushed the uncountable-integer-1 branch from 74fe4ca to a62b29d Compare July 17, 2025 21:47
@rust-log-analyzer
Copy link
Collaborator

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[TIMING] core::build_steps::tool::Tidy { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu } -- 0.000
fmt check
fmt: checked 6161 files
tidy check
tidy error: `ISSUES_ENTRY_LIMIT` is too high (is 1616, should be 1575)
Checking tidy rustdoc_json...
Running eslint on rustdoc JS files
No error code explanation was removed!
tidy: Skipping binary file check, read-only filesystem
removing old virtual environment
---
All checks passed!
checking python file formatting
28 files already formatted
checking C++ file formatting
some tidy checks failed
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:01:21
  local time: Thu Jul 17 21:53:35 UTC 2025
  network time: Thu, 17 Jul 2025 21:53:36 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants