Skip to content

rust-analyzer backports #143794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: beta
Choose a base branch
from
Open

rust-analyzer backports #143794

wants to merge 5 commits into from
+562 −110

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Jul 11, 2025

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2025

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 11, 2025
@lnicola lnicola changed the title Ra backports rust-analyzer backports Jul 11, 2025
ShoyuVanilla
ShoyuVanilla approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@ShoyuVanilla ShoyuVanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not on the compiler team, but as a member of the rust-analyzer team who worked on these commits, I believe this has been done correctly 😄

@Urgau Urgau mentioned this pull request Jul 11, 2025
Merged
@cuviper
Copy link
Member

cuviper commented Jul 11, 2025

LGTM!

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jul 11, 2025

📌 Commit 07d659c has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2025
@cuviper cuviper added beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lnicola @rustbot @cuviper @bors @ShoyuVanilla @Mark-Simulacrum @Veykril