Disambiguate between rustc vs std having debug assertions in run-make-support
and run-make
tests
#143782
+27
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO_DEBUG_ASSERTIONS
is set by CI that threads through to the./configure.py
script, which is somewhat fragile and "spooky action at a distance". Forfmt-write-bloat
, this is actually wrong because the test wants to gate on std being built with debug assertions or not, whereasNO_DEBUG_ASSERTIONS
determines rustc being built with debug assertions or not. Instead, use env vars controlled by compiletest, whose debug assertion info comes from bootstrap.rust/src/ci/run.sh
Lines 137 to 146 in 855e0fe
NO_DEBUG_ASSERTIONS
controls--enable-debug-assertions
rust/src/bootstrap/configure.py
Line 124 in 855e0fe
which sets
--rust.debug-assertions
, which controls rustc debug assertions.rust/src/bootstrap/configure.py
Lines 125 to 129 in 855e0fe
--rust.debug-assertions-std
controls std debug assertions.Noticed while investigating
fmt-write-bloat
in #143669 (comment).Best reviewed commit-by-commit.
r? @ChrisDenton (or compiler/bootstrap)